anthropics/claude-plugins-official
1
0
Fork 0
mirror of https://github.com/anthropics/claude-plugins-official.git synced 2026-05-11 22:15:52 -03:00
Code Issues Packages Projects Releases Wiki Activity

fix(telegram): verify stale PID is a server.ts process before SIGTERM

Browse Source 
PID files race with OS PID recycling. The lockfile from #1349 stored only a
PID; after enough churn that PID can be reassigned to anything — including
the new launch's own bun-run wrapper. SIGTERMing the wrapper closes our
stdin and triggers immediate self-shutdown ('replacing stale poller' then
'shutting down' within seconds — matches #1459 item 3).

Now check 'ps -p <pid> -o args=' contains 'server.ts' before killing.
execFileSync (no shell); whole block already try/catch so Windows/ps-missing
falls through to just overwriting the lockfile.
This commit is contained in:
Claude 2026-04-17 18:50:12 +00:00
parent 223c9b2922
commit 6ceddea179
No known key found for this signature in database
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
external_plugins/telegram/server.ts
View File

@ -21,6 +21,7 @@ import type { ReactionTypeEmoji } from 'grammy/types'
import { randomBytes } from 'crypto'
import { readFileSync, writeFileSync, mkdirSync, readdirSync, rmSync, statSync, renameSync, realpathSync, chmodSync } from 'fs'
import { homedir } from 'os'
import { execFileSync } from 'child_process'
import { join, extname, sep } from 'path'
const STATE_DIR = process.env.TELEGRAM_STATE_DIR
@ -63,8 +64,15 @@ try {
const stale = parseInt(readFileSync(PID_FILE, 'utf8'), 10)
if (stale > 1 && stale !== process.pid) {
process.kill(stale, 0)
process.stderr.write(`telegram channel: replacing stale poller pid=${stale}\n`)
process.kill(stale, 'SIGTERM')
// PID files race with OS PID recycling — verify the holder is actually a
// server.ts process before SIGTERM. Otherwise a recycled PID can point at
// our own bun-run wrapper (kills our stdin → immediate self-shutdown) or
// an unrelated user process.
const cmd = execFileSync('ps', ['-p', String(stale), '-o', 'args='], { encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] })
if (cmd.includes('server.ts')) {
process.stderr.write(`telegram channel: replacing stale poller pid=${stale}\n`)
process.kill(stale, 'SIGTERM')
}
}
} catch {}
writeFileSync(PID_FILE, String(process.pid))